DRAFT: theme/powerline-plain: delete powerline-plain/powerline.base
#2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
theme/powerline-plain
branch
6 times, most recently
from
b50ba2d
to
4984320
Compare
gaelicWizard
force-pushed
the
theme/powerline-plain
branch
2 times, most recently
from
4b1c50b
to
783196b
Compare
gaelicWizard
force-pushed
the
theme/powerline-plain
branch
4 times, most recently
from
60c52f6
to
8fa81e8
Compare
- Local some variables,
- install reasonable defaults, based on `theme/powerline-plain` which doens't use the special font,
- Use `\D{fmt}` instead of `$(date +fmt)`.
Alsö:
- Use `\u` instead of `${SHORT_USER:-${USER?}}`.
- Use `if`/`then` properly.
- Lose some whitespace from prompt characters; that's what padding is for.
TODO:
- prompt character prefix/suffix support
- use variables rather than subshells...
gaelicWizard
force-pushed
the
theme/powerline-plain
branch
from
8fa81e8
to
512dd1b
Compare
It seems like the copied functions were just slightly out of date without any altered functionality. The one actual difference was `$POWERLINE_PROMPT_AFTER` which is blank by default and is not documented anywhere and is not used anywhere and...I will guess it's not used. This theme seems to be about not using the powerline font, as opposed to being "simpler" in some way.
Use `$POWERLINE_PROMPT_CHAR` instead of `$POWERLINE_PROMPT_AFTER`
gaelicWizard
force-pushed
the
theme/powerline-plain
branch
from
512dd1b
to
2120518
Compare
gaelicWizard
changed the title
powerline-plain/powerline.basepowerline-plain/powerline.base
|
Is This still a thing? |
seefood
added
clean up
seems abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The functions in
powerline-plain/powerline.basewere nearly identical after updating, so just delete the extra file. The difference from "regular" seems to just be not using the powerline font, and that's handled already by setting the right prompt character variables. Alsö, linttheme/powerline-plain.Motivation and Context
Simplicity, predictability, &c.
How Has This Been Tested?
Since I haven't used the powerline* themes much, this is hard for me to test as I'm not used to what "normal" looks like.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.