-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose scale
of CachedNetworkImageProvider on CachedNetworkImage
#576
Conversation
8954fc5
to
e2d8ee6
Compare
It looks like the CI failure is not related to my changes:
|
e2d8ee6
to
636db53
Compare
I've resolved the conflicts. |
Please merge this PR, really useful! |
One use case could be to use it with a seamless image pattern and repeat option, in order to scale the pattern. |
Any plan to merge this? |
636db53
to
b44c05b
Compare
I've resolved the conflicts again. |
This test failure appears to be spurious. |
If you don't plan to merge this PR, could you at least tell why and close it? |
21fd20b
to
2e82902
Compare
2e82902
to
57854a6
Compare
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This PR exposes the
scale
argument ofCachedNetworkImageProvider
in theCachedNetworkImage
constructor.Currently you cannot set the
scale
used by the implicitly instantiatedCachedNetworkImageProvider
, so if you need to set the image scale then you have to use something likeImage(image: CachedNetworkImageProvider(url))
so you can't take advantage of the various nice features ofCachedNetworkImage
.🆕 What is the new behavior (if this is a feature change)?
Now you can pass the
scale
argument.💥 Does this PR introduce a breaking change?
No. The argument has the same default as
CachedNetworkImageProvider
so the behavior is unchanged if not supplied.🐛 Recommendations for testing
Try supplying different values of
scale
toCachedNetworkImage
and ensure they take effect.📝 Links to relevant issues/docs
#572
🤔 Checklist before submitting