Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start position stream after enabling location service #1497

Merged
merged 2 commits into from
May 2, 2024

Conversation

mvanbeusekom
Copy link
Member

Fixes a bug where a new instance of the GeolocationManager is created and results from the location service resolution process are not delivered to the correct instance, resulting in the location stream to be cancelled or not started at all.

Fixes #1149

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@mvanbeusekom mvanbeusekom merged commit 9b7a049 into main May 2, 2024
1 check passed
@mvanbeusekom mvanbeusekom deleted the feature/remove_v1_embedding branch May 2, 2024 07:03
@RabbitQuestBV
Copy link

Hi Maurits,

Singletons for the win.

Looks great. When is it expected that this is available on the Flutter Geolocator Package?
(https://pub.dev/packages/geolocator/versions)

Kind regards,
Bart

@mvanbeusekom
Copy link
Member Author

Hahaha in this case definitely ;).

The update has been published (https://pub.dev/packages/geolocator_android/changelog) and should automatically be downloaded if you run a flutter pub upgrade. To verify check the contents of the pubspec.lock file and look for the version of the geolocator_android package (this should be 4.5.5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants