Skip to content

Commit

Permalink
improvement: added test pipeline
Browse files Browse the repository at this point in the history
  • Loading branch information
BartSte committed Dec 31, 2023
1 parent 3e2b24a commit b598d45
Show file tree
Hide file tree
Showing 10 changed files with 2,953 additions and 8 deletions.
38 changes: 38 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Tests

on:
push:
branches:
- main
- develop
pull_request:
branches:
- main
- develop

jobs:
run-tests:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Update apt-get database
run: sudo apt-get update

- name: Install build dependencies
run: sudo apt-get install -y clang ninja-build git cmake

- name: Install project dependencies
run: sudo apt-get install -y libboost-all-dev libspdlog-dev qt6-base-dev qt6-multimedia-dev libgl1-mesa-dev libvulkan-dev libxkbcommon-dev libqt6multimedia6 libqt6multimediaquick6 libqt6multimediawidgets6 qml6-module-qtmultimedia

- name: Build project
run: |
cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTS=ON
cmake --build build
- name: Run tests
env:
QT_MEDIA_BACKEND: ffmpeg
run: ctest --test-dir ./build --verbose
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ option(BUILD_TESTS "Build tests" OFF)
message(STATUS "Build type: ${CMAKE_BUILD_TYPE}")
message(STATUS "Build tests: ${BUILD_TESTS}")

set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

set(CMAKE_AUTOMOC ON)
Expand Down
22 changes: 21 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ Ensure the following dependencies are installed:
| Dependency | Version |
| ------------------------------------------------------------- | -------- |
| [Qt6](https://www.qt.io/download): base & multimedia (ffmpeg) | ≥ 6.6.0 |
| [cxxopts](https://github.com/jarro2783/cxxopts) | ≥ 3.1.1 |
| [boost](https://www.boost.org/) | ≥ 1.83 |
| [spdlog](https://github.com/gabime/spdlog) | ≥ 1.12.0 |

Expand All @@ -68,6 +67,10 @@ For building the project, the following dependencies are required:
- [CMake](https://cmake.org/download/)
- [Ninja](https://ninja-build.org/)

`cxxopts` and `googletest` are also dependencies, but they are included in the
project. The former as a header file in the `extern` directory, and the latter
is installed using `cmake`.

## Installation

The following sections explain how to install the project. You have two
Expand Down Expand Up @@ -362,6 +365,23 @@ more information.

# TODO:

- [ ] test pipeline:

- I get the following error when running the tests in a github workflow using
ubuntu-latest:
```bash
qt.multimedia.player: Warning: "No decoder available for type 'video/quicktime, variant=(string)iso'."
```
I tried the following:
- Set the QT_MEDIA_BACKEND to ffmpeg as the website suggests this is more
stable.
- Install all qt6 multimedia packages I could find.

Interesting is that I get the same error when when I set the QT_MEDIA_BACKEND
to gstreamer on my Arch Linux machine. I was able to fix this partially by
installing many gstreamer packages. However, I want ffmpeg so switching to
gstreamer is not an option (it is also not recommended by the qt website).

- [ ] Add pre built binaries to the github releases
- [ ] Add an uninstall target?
- [ ] Cross compile for raspberry pi
Loading

0 comments on commit b598d45

Please sign in to comment.