Skip to content

Commit

Permalink
fix: quitWhenHeadless called quit() when the recording was running
Browse files Browse the repository at this point in the history
  • Loading branch information
BartSte committed Jan 22, 2024
1 parent 53f1a07 commit 9725d5c
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 2 deletions.
37 changes: 37 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,15 @@ more information.
- [ ] Cross compile for raspberry pi
- [ ] Segmentation fault when running --record without a camera being
available.
- [ ] Fix issue with ffmpeg + hw acceleration on my arch machine:

```
[h264 @ 0x5594b31d6b40] A hardware frames or device context is required for hardware accelerated decoding.
[h264 @ 0x5594b31d6b40] Failed setup for format vaapi: hwaccel initialisation returned error.
```

When solved, document it in the faq.

- [ ] Add to FAQ:

- WSL + ubuntu:
Expand All @@ -442,6 +451,34 @@ more information.

- qt.qpa.wayland: EGL not available .

- Issues with your graphics card need to be resolved by the user itself. You
need to setup your graphics card yourself. Here are some tips:

For Intel graphics cards:

- Most Linux-based* distributions already include Intel® Graphics Drivers.
These drivers are provided and maintained by the Linux* distribution
vendors and not by Intel, we recommend contacting the Linux\* Operating
System Vendors.
- On arch, ffmpeg gave warnings that harware acceleration did not work.
After installing the `libva-intel-driver` the issue was resolved.

For Nvidia graphics cards:

- TODO

For AMD graphics cards:

- TODO

Checkout the arch wiki for more information:

- [General](https://wiki.archlinux.org/title/Hardware_video_acceleration)
- [Intel](https://wiki.archlinux.org/title/Intel_graphics)
- [Nvidia](https://wiki.archlinux.org/title/NVIDIA)
- [Nouveau](https://wiki.archlinux.org/title/Nouveau)
- [AMD](https://wiki.archlinux.org/title/AMDGPU)

- Issues graphics on WSL. I get the following error:

```
Expand Down
7 changes: 5 additions & 2 deletions src/snapshotapp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,11 @@ void App::makeRecorder() {
* @brief Quit when the recorder is stopped and no gui is active.
*/
void App::quitWhenHeadless() {
spdlog::debug("Quit if no gui is active");
if (guiActive()) {
spdlog::debug("quitWhenHeadless called");
if (recorder->getState() != RecorderState::Stop) {
spdlog::debug("Recorder is not stopped.");
return;
} else if (guiActive()) {
spdlog::debug("Gui is active");
return;
} else if (App::closingDown()) {
Expand Down

0 comments on commit 9725d5c

Please sign in to comment.