Resolves #75: New info sidebar #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issue-75-info-sidebar # Conflicts: # game/options/src/main/kotlin/de/gleex/pltcmd/game/options/UiOptions.kt # game/ui/src/main/kotlin/de/gleex/pltcmd/game/ui/fragments/ElementCommandFragment.kt # game/ui/src/main/kotlin/de/gleex/pltcmd/game/ui/views/GameView.kt
# Conflicts: # game/ui-strings/pom.xml # game/ui-strings/src/main/kotlin/de/gleex/pltcmd/game/ui/strings/FrontendString.kt # game/ui-strings/src/main/kotlin/de/gleex/pltcmd/game/ui/strings/extensions/ComponentExtensions.kt # game/ui-strings/src/main/kotlin/de/gleex/pltcmd/game/ui/strings/extensions/ToFrontendString.kt # game/ui/src/main/kotlin/de/gleex/pltcmd/game/ui/fragments/CoordinateAtMousePosition.kt
Loomie
reviewed
Nov 7, 2020
.../src/main/kotlin/de/gleex/pltcmd/game/ui/fragments/tileinformation/TerrainDetailsFragment.kt
Outdated
Show resolved
Hide resolved
Loomie
reviewed
Nov 7, 2020
Loomie
reviewed
Nov 7, 2020
Loomie
reviewed
Nov 7, 2020
There was a problem hiding this comment.
I think we should define what should be highlighted bold in the info panel as it is currently not very consistent. Either all titles should be bold as a header. Or the important information like the coordinate is highlighted to be easily readable.
For the code see comments.
with space or P
Yes, I will redesign the sidebar a bit. It probably looks best to have the titles be bold and have the content in a new line, a bit indented like so: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #75