Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 155 combat defense #157

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Issue 155 combat defense #157

wants to merge 18 commits into from

Conversation

Loomie
Copy link
Collaborator

@Loomie Loomie commented Oct 14, 2021

No description provided.

@Loomie Loomie linked an issue Oct 14, 2021 that may be closed by this pull request
Implement defensive behavior for fighting elements #155
Open
@Loomie
Copy link
Collaborator Author

Loomie commented Oct 14, 2021

I put up some enums for different states:

  • MovementState
  • CoverState
  • AwarenessState

All implement the interface DefenseFactor and provide a double value to describe by what amount the hit chance is reduced. Pretty simple.

The factors are created by the CombatEntity. Currently that is pretty basic. It can be used for further additions.

@Loomie Loomie requested a review from Baret October 14, 2021 18:03
Baret
Baret requested changes Oct 14, 2021
View reviewed changes
Copy link
Owner

@Baret Baret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Easy to extend later, I like that.
I just have some minor comments.

game/engine/src/main/kotlin/de/gleex/pltcmd/game/engine/entities/types/Combatant.kt Outdated Show resolved Hide resolved
game/engine/src/main/kotlin/de/gleex/pltcmd/game/engine/entities/types/Combatant.kt Outdated Show resolved Hide resolved
game/engine/src/main/kotlin/de/gleex/pltcmd/game/engine/entities/types/Combatant.kt Outdated Show resolved Hide resolved
model/combat/src/main/kotlin/de/gleex/pltcmd/model/combat/defense/CoverState.kt Show resolved Hide resolved
model/combat/src/main/kotlin/de/gleex/pltcmd/model/combat/defense/DefenseFactor.kt Outdated Show resolved Hide resolved
model/combat/src/main/kotlin/de/gleex/pltcmd/model/combat/defense/DefenseFactor.kt Outdated Show resolved Hide resolved
model/combat/src/main/kotlin/de/gleex/pltcmd/model/combat/defense/MovementState.kt Outdated Show resolved Hide resolved
model/combat/src/main/kotlin/de/gleex/pltcmd/model/combat/defense/TotalDefense.kt Outdated Show resolved Hide resolved
@Baret Baret added the feature A completely new feature label Oct 14, 2021
@Baret Baret added this to the v0.2.0 Fighting elements milestone Oct 14, 2021
@Loomie Loomie requested a review from Baret October 17, 2021 08:32
Baret
Baret requested changes Oct 20, 2021
View reviewed changes
Copy link
Owner

@Baret Baret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let us not use the world map to dynamically calculate the defense ;)

game/engine/src/main/kotlin/de/gleex/pltcmd/game/engine/entities/types/Combatant.kt Outdated Show resolved Hide resolved
@Loomie Loomie requested a review from Baret October 23, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baret Baret Awaiting requested review from Baret

Assignees

@Loomie Loomie

Labels
feature A completely new feature
Projects
None yet
Milestone
v0.2.0 Fighting elements
Development

Successfully merging this pull request may close these issues.

Implement defensive behavior for fighting elements
2 participants
@Loomie @Baret