Skip to content

Commit

Permalink
Merge pull request #132 from Banno/updates
Browse files Browse the repository at this point in the history
Update gradle, java, kotlin, agp, target sdk
  • Loading branch information
joshschriever authored Nov 13, 2024
2 parents d48606c + 870bc83 commit 856bbab
Show file tree
Hide file tree
Showing 20 changed files with 349 additions and 239 deletions.
10 changes: 10 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
[*.{kt,kts}]
ktlint_code_style = intellij_idea
ktlint_standard_annotation = disabled
ktlint_standard_class-signature = disabled
ktlint_standard_comment-spacing = disabled
ktlint_standard_condition-wrapping = disabled
ktlint_standard_multiline-if-else = disabled
ktlint_standard_spacing-between-declarations-with-annotations = disabled
ktlint_standard_trailing-comma-on-call-site = disabled
ktlint_standard_trailing-comma-on-declaration-site = disabled
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 17
java-version: 21

- uses: gradle/actions/setup-gradle@v4

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 17
java-version: 21

- uses: gradle/actions/setup-gradle@v4

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 17
java-version: 21

- uses: gradle/actions/setup-gradle@v4

Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ build
/captures
.externalNativeBuild
.cxx
.kotlin
3 changes: 0 additions & 3 deletions .idea/codeStyles/Project.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
tasks.wrapper {
distributionType = Wrapper.DistributionType.ALL
gradleVersion = "latest"
}

tasks.register<Delete>("clean") {
delete(buildDir)
delete(layout.buildDirectory)
}
9 changes: 7 additions & 2 deletions gordon-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dependencies {
implementation("org.jetbrains.kotlinx:kotlinx-html:0.7.3")

implementation("com.android.tools.build:gradle:$androidGradlePluginVersion")
implementation("com.android.tools.build:bundletool:1.14.1")
implementation("com.android.tools.build:bundletool:1.17.2")
implementation("com.google.guava:guava:30.1.1-jre")
implementation("org.smali:dexlib2:2.5.2")

Expand All @@ -27,9 +27,14 @@ dependencies {
testImplementation("io.mockk:mockk:1.12.0")
}

tasks.withType<JavaCompile>().configureEach {
sourceCompatibility = "21"
targetCompatibility = "21"
}

tasks.withType<KotlinCompile>().configureEach {
kotlinOptions {
jvmTarget = "17"
jvmTarget = "21"
}
}

Expand Down
2 changes: 1 addition & 1 deletion gordon-plugin/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
group=com.banno.gordon
version=1.10.2
version=1.11.0
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ internal fun Project.androidPlugin(): AndroidPlugin<*, *>? =
}

internal sealed class AndroidPlugin<
out T : CommonExtension<*, *, *, *>,
out T : CommonExtension<*, *, *, *, *, *>,
out U : AndroidComponentsExtension<out T, *, *>
> {

Expand Down
9 changes: 5 additions & 4 deletions gordon-plugin/src/main/kotlin/com/banno/gordon/TestResults.kt
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
@file:Suppress("ktlint:standard:no-wildcard-imports")

package com.banno.gordon

import kotlinx.html.* // ktlint-disable no-wildcard-imports
import kotlinx.html.*
import kotlinx.html.stream.appendHTML

internal sealed class TestResult {
Expand All @@ -27,10 +29,9 @@ internal sealed class TestResult {

data class Failure(val duration: Float?, val shellOutput: String, val deviceSerial: String)

internal inline fun <reified T : TestResult> Map<TestCase, TestResult>.filterResultType(): Map<TestCase, T> {
return filterValues { it is T }
internal inline fun <reified T : TestResult> Map<TestCase, TestResult>.filterResultType(): Map<TestCase, T> =
filterValues { it is T }
.mapValues { it.value as T }
}

internal fun Map<PoolName, Map<TestCase, TestResult>>.getTestCasesByResult(predicate: (TestResult) -> Boolean): Map<PoolName, List<TestCase>> =
mapValues {
Expand Down
11 changes: 6 additions & 5 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
androidGradlePluginVersion=8.0.0
aapt2Version=8.0.0-9289358
kotlinVersion=1.8.10
kotlinterVersion=3.8.0
gradlePluginPublishVersion=1.2.0
androidGradlePluginVersion=8.7.2
aapt2Version=8.7.2-12006047
kotlinVersion=1.9.25
kotlinterVersion=4.4.1
gradlePluginPublishVersion=1.3.0
org.gradle.caching=true
org.gradle.configuration-cache=true
org.gradle.configuration-cache.parallel=true
org.gradle.daemon=true
org.gradle.jvmargs=-Xmx1536m
org.gradle.parallel=true
Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
4 changes: 3 additions & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11-all.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-all.zip
Loading

0 comments on commit 856bbab

Please sign in to comment.