Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWI-1694: Update test and deployment workflows #76

Merged
merged 4 commits into from
Oct 19, 2023
Merged

SWI-1694: Update test and deployment workflows #76

merged 4 commits into from
Oct 19, 2023

Conversation

juliajanu
Copy link
Contributor

No description provided.

@juliajanu juliajanu marked this pull request as ready for review October 18, 2023 19:57
@juliajanu juliajanu requested a review from a team October 18, 2023 19:57
ajrice6713
ajrice6713 reviewed Oct 18, 2023
View reviewed changes
.github/workflows/deploy.yml
Comment on lines +83 to +84
BW_PROJECT_NAME: src/Bandwidth.Standard
BW_PROJECT_TEST_NAME: src/Bandwidth.Standard.Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these gonna be correct with the src in there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was basing this off of the following step

      - name: Run integration tests
        run: dotnet test $BW_PROJECT_TEST_NAME

dotnet test BW_PROJECT_TEST_NAME fails if BW_PROJECT_TEST_NAME=Bandwidth.Standard.Test I figured BW_PROJECT_NAME would be the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test-pr workflow passed and it has the following step

- name: Run functional tests
        env:
          OPERATING_SYSTEM: ${{ matrix.os }}
          CSHARP_VERSION: ${{ matrix.dotnet }}
          # Required for multiple target frameworks in the StandardTests project.
          DOTNET: ${{ matrix.dotnet }}
        run: dotnet test src/Bandwidth.Standard.Test

so we know that BW_PROJECT_TEST_NAME will work for sure

@juliajanu juliajanu merged commit e5e6390 into feature/openapi-generator-sdk Oct 19, 2023
8 checks passed
@juliajanu juliajanu deleted the SWI-1694 branch October 19, 2023 16:27
juliajanu added a commit that referenced this pull request Dec 22, 2023
@juliajanu @ajrice6713 @ckoegel
SWI-4079: Merging feature branch with main! (#91)
996509f 
* Remove all previous SDK remnants

* Add bandwidth.json spec

* Generate SDK using Openapi Generator CLI

```openapi-generator-cli generate -g csharp-netcore -i bandwidth.json -c openapi-config.yml```

* Add empty integration test files

* add .vscode to gitignore

* Remove vscode files

* SWI-1670: Refactoring .NET Verbs  (#69)

* SWI-1645: adding Root BXML verbs

* SWI-1645: Update test file name

* SWI-1645: Update test file name one more time

* SWI-1645: Update versions of actions used in test workflow

* SWI-1645: Update runner version

* SWI-1645: Update action versions in deploy action

* SWI-1670: Revert changes to old BXML

* SWI-1670: Updated serialization library used

* SWI-1670: Adding new Verbs

* SWI-1670: Updating gitignore

* SWI-1670: Updating verbs

* SWI-1670: Update Conference file to be uppercase

* Update .github/workflows/deploy.yml

Co-authored-by: AJ Rice <[email protected]>

* SWI-1670: Fixing comments and adding getters and setters where they were missing

---------

Co-authored-by: AJ Rice <[email protected]>

* SWI-3245: Write Tests for the BXML Verbs (#70)

* SWI-3245: Adding test files for verbs

* SWI-3245: Adding test files for verbs for real

* SWI-3245: all tests are written

* SWI-3245: Adding DS_store to gitignore

* SWI-3245: Add missing package

* SWI-3245: Update netcore framework version used

* SWI-3245: Fixing tests

* SWI-3245: Updating tests again

* SWI-3245: Update tests

* SWI-3245: Add space to expected string for verbs with no attributes & context

* SWI-3245: Update Tests to Target .NET 6 & 7

* SWI-1687: [.NET] Unit Tests for API Models (#71)

* SWI-1687: Updating OpenAPI generated tests

* SW-1687: finished up tests

* SWI-1687: Formatting changes

* SWI:1687: Update config files

* SWI-1687: Remove additionalProperties tag in config file

* Update openapi-config.yml

Co-authored-by: Cameron Koegel <[email protected]>

* SWI-1687: I wanted it in alphabetical order

---------

Co-authored-by: Cameron Koegel <[email protected]>

* SWI-3341: Update to OpenAPI Generator 7.0.0 (#72)

* SWI-3342: generated with newest API spec file and added a new test (#73)

* SWI-1680: [.NET] Unit Tests for APIs (#74)

* SWI-3342: generated with newest API spec file and added a new test

* SWI-1680: Added API Unit tests

* SWI-1680: Update Test csproj file

* SWI-1680: Trying to fix tests with streams

* SWI-1632: [.NET] API Integration Tests (#75)

* SWI-1632: Working on API integration tests

* SWI-1632: Finished integration tests

* SWI-1632: Added environment variables to workflows

* SWI-1632: Added forbidden user & pass to workflows

* SWI-1632: Added rate limit test

* SWI-1632: Updating request to number

* SWI-1632: Trying to get media tests to work

* SWI-1632: General reformatting

* SWI-1694: Update test and deployment workflows (#76)

* SWI-1694: Updated test workflows

* SWI-1694: Adding feature branch to nightly test

* SWI-1694: Update deploy workflow

* SWI-1694: Update deploy to handle pre-releases

* SWI-1694: Update deployment workflow (#77)

* SWI-1694: Updated test workflows

* SWI-1694: Adding feature branch to nightly test

* SWI-1694: Update deploy workflow

* SWI-1694: Update deploy to handle pre-releases

* SWI-1694: fix conditional statement

* SWI-1694: Updated regex

* SWI-1694: Update CODEOWNERS

* SWI-1694: Updating echo command to be nicer

* SWI-1695: updating the regex again (#78)

* SWI-1695: Fix regex for new releases (#79)

* SWI-1695: updating the regex again

* SWI-1695: updating the regex again pt.2

* SWI-1695: removed comment

* SWI-1695: Update quotes

* SWI-1695: Adding a missing environment variable (#80)

* SWI-1695: updating the regex again

* SWI-1695: updating the regex again pt.2

* SWI-1695: removed comment

* SWI-1695: Update quotes

* SWI-1695: Add missing environment variable

* Update deploy.yml

* SWI-1695: Updated env vars

* SWI-1696:  Finishing touches before beta release (#81)

* SWI-1696:  Update csproj and openapi ignore files

* Update src/Bandwidth.Standard/Bandwidth.Standard.csproj

Co-authored-by: AJ Rice <[email protected]>

* Update src/Bandwidth.Standard/Bandwidth.Standard.csproj

Co-authored-by: AJ Rice <[email protected]>

---------

Co-authored-by: AJ Rice <[email protected]>

* SWI-3915: Regenerate C# SDK and add tests for new endpoint (#82)

* SWI-3915: Regenerated SDK & added tests for new endpoint

* SWI-3915: Uncomment [Fact]

* SWI-3915: Fix list calls api test

* SWI-3933: Regenerated with version 7.1.0 (#83)

* SWI-3945: Adding "update-sdk" workflow (#84)

* SWI-3945: Add an update SDK workflow

* Update .github/workflows/update-sdk.yml

Co-authored-by: Cameron Koegel <[email protected]>

---------

Co-authored-by: Cameron Koegel <[email protected]>

* SWI-4077: Remove the update-sdk workflow (#90)

---------

Co-authored-by: AJ Rice <[email protected]>
Co-authored-by: Cameron Koegel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckoegel ckoegel ckoegel approved these changes

@ajrice6713 ajrice6713 ajrice6713 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliajanu @ajrice6713 @ckoegel