Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added socials and quick links #36

Merged
merged 7 commits into from
Jun 2, 2024
Merged

added socials and quick links #36

merged 7 commits into from
Jun 2, 2024

Conversation

Asymtode712
Copy link
Contributor

@Asymtode712 Asymtode712 commented May 28, 2024

Fixes #34

@BamaCharanChhandogi I have added a "/contact" route in quick link as a reference from #33 , so merge this PR first then go for my PR

Also, please add labels and assign me this PR

Thank you!

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diabetes-prediction ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 6:11pm

@BamaCharanChhandogi
Copy link
Owner

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Asymtode712
Copy link
Contributor Author

@BamaCharanChhandogi till the time please merge my remaining workflow PRs

@BamaCharanChhandogi
Copy link
Owner

@BamaCharanChhandogi till the time please merge my remaining workflow PRs

I have already reviewed workflow PRs. You need to update something. Please look at the PR.

@Asymtode712
Copy link
Contributor Author

@BamaCharanChhandogi till the time please merge my remaining workflow PRs

I have already reviewed workflow PRs. You need to update something. Please look at the PR.

@BamaCharanChhandogi I checked each PR but there are no requested changes or updation by you

they are only reamaining with merge

@BamaCharanChhandogi
Copy link
Owner

@BamaCharanChhandogi till the time please merge my remaining workflow PRs

I have already reviewed workflow PRs. You need to update something. Please look at the PR.

@BamaCharanChhandogi I checked each PR but there are no requested changes or updation by you

they are only reamaining with merge

Do you see this type of review?
image

@Asymtode712
Copy link
Contributor Author

@BamaCharanChhandogi No, should I change the PATs?

@BamaCharanChhandogi
Copy link
Owner

@BamaCharanChhandogi No, should I change the PATs?

yes

@BamaCharanChhandogi
Copy link
Owner

BamaCharanChhandogi commented May 30, 2024

image

Do you see this review? any update?

@Asymtode712
Copy link
Contributor Author

@BamaCharanChhandogi No, I saw it now will make the changes quickly

@Asymtode712
Copy link
Contributor Author

@BamaCharanChhandogi Done with the changes

@BamaCharanChhandogi
Copy link
Owner

I do not know why my reviews are not visible to you. I just wanted to let you know that I requested more changes.

  1. why do you use a, I said that you must use the Link tag in pages.
  2. you can add rest page links according to the navbar.

@Asymtode712
Copy link
Contributor Author

@BamaCharanChhandogi I will replace all the occuraces of a with Link but for navigation from footer we dont have any About page at the moment right so where should I navigate About to?

@Asymtode712
Copy link
Contributor Author

@BamaCharanChhandogi I have replaced all instances of a with Link and for now About in footer navigates to Home page

@BamaCharanChhandogi
Copy link
Owner

@BamaCharanChhandogi I have replaced all instances of a with Link and for now About in footer navigates to Home page

You can add FAQ section instead of about

@Asymtode712
Copy link
Contributor Author

@BamaCharanChhandogi Ok as you say

@Asymtode712
Copy link
Contributor Author

@BamaCharanChhandogi Done with the changes please review

Copy link
Owner

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

client/src/components/Footer.jsx Outdated Show resolved Hide resolved
client/src/components/Footer.jsx Outdated Show resolved Hide resolved
client/src/components/Footer.jsx Outdated Show resolved Hide resolved
@BamaCharanChhandogi BamaCharanChhandogi merged commit 25441cf into BamaCharanChhandogi:main Jun 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Adding social media and quick links
2 participants