Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding USDC and injector for CoW ARB/wETH pool #1348

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

Zen-Maxi
Copy link
Collaborator

Adding USDC as reward with USDC injector as distributor to Cow ARB/weTH pool.

Copy link
Contributor

FILENAME: MaxiOps/add_rewards/arbitrum/Add_USDC_Cow-ARB-wETH-Injector.json
COMMIT: 52e3531f262da152f358e8094564e15a8459bb38

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip ❌ (No BIP number found in file path MaxiOps/add_rewards/arbitrum/Add_USDC_Cow-ARB-wETH-Injector.json)
validate_path_has_weekly_dir ❌ (File MaxiOps/add_rewards/arbitrum/Add_USDC_Cow-ARB-wETH-Injector.json has has no YYYY-W## in path)

Copy link
Contributor

FILENAME: MaxiOps/add_rewards/arbitrum/Add_USDC_Cow-ARB-wETH-Injector.json
MULTISIG: multisigs/lm (arbitrum:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 52e3531f262da152f358e8094564e15a8459bb38
CHAIN(S): arbitrum
TENDERLY: 🟩 SUCCESS

+---------------+-----------------------------------------------------------------------------------------------------------------+---------------------------------------------------+-----------------------------+-----------------------------------------------------------------------------------------------------+-----+----------+
| function      | entrypoint                                                                                                      | target                                            | selector                    | parsed_inputs                                                                                       | bip | tx_index |
+---------------+-----------------------------------------------------------------------------------------------------------------+---------------------------------------------------+-----------------------------+-----------------------------------------------------------------------------------------------------+-----+----------+
| performAction | 0x97207B095e4D5C9a6e4cfbfcd2C3358E03B90c4A (20221124-authorizer-adaptor-entrypoint/AuthorizerAdaptorEntrypoint) | 0xbDBc27A1C245ed52EAcb0dc6ebA922992328F303 (None) | add_reward(address,address) | 0xaf88d065e77c8cC2239327C5EDb3A432268e5831: USDC                                                    | N/A |    0     |
|               |                                                                                                                 |                                                   |                             | 0xabC414cEE2F6E8Ee262d6dc106c86A3f627f84D2: maxiKeepers/gaugeRewardsInjectors/usdc_rewards_injector |     |          |
+---------------+-----------------------------------------------------------------------------------------------------------------+---------------------------------------------------+-----------------------------+-----------------------------------------------------------------------------------------------------+-----+----------+

Copy link
Member

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gauge is not labelled because it does not come back as a preferential gauge in the old subgraph, and is therefore ignored by the address book. will be solved by BalancerMaxis/bal_addresses#399

it is however the correct gauge.

old subgraph results:

{
  "data": {
    "liquidityGauges": [
      {
        "id": "0xbdbc27a1c245ed52eacb0dc6eba922992328f303",
        "symbol": "BCoW-50ARB-50WETH-gauge",
        "isPreferentialGauge": false
      }
    ]
  }
}

apiv3:

{
  "data": {
    "poolGetPool": {
      "staking": {
        "gauge": {
          "gaugeAddress": "0xbdbc27a1c245ed52eacb0dc6eba922992328f303"
        }
      }
    }
  }
}

@Zen-Maxi Zen-Maxi merged commit 8857632 into main Sep 16, 2024
@Zen-Maxi Zen-Maxi deleted the Add_USDC_Cow-ARB-wETH-Injector branch September 16, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants