Serial Support #344
Open
Serial Support #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very interesting work! Could you rebase this instead? I can't tell exactly which changes are yours and which are from the merge commit. Also, you seem to change some of the formatting in the files. You should use |
|
@Artucuno how do I test/use the serial connection through pyboy with these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Reopened #337)
Tested in:
Issues:
There is a small issue where the emulator will temporarily freeze when waiting for the other Gameboy to respond to data (Should be an easy fix for someone)- Fixed in 7878718 & fa3eaaaSynchronization issues in some games, however Pokémon games work completely fine.Fixed in fa3eaaaWhen compiled into Cython, PyBoy freezes after socket connection is establishedFixed in fa3eaaa