Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow possibility of using #liq as incentive in liquis marketplace paladin #1469

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

petrovska-petro
Copy link
Collaborator

@petrovska-petro petrovska-petro commented Dec 20, 2023

closes #1468

params for testing:

    badger_bribe_in_aura=0,
    badger_bribe_in_balancer=0,
    badger_bribe_in_votium=0,
    badger_bribe_in_frax=0,
    badger_bribe_in_bunni=0,  # NOTE: dollar denominated. Badger calculation is done internaly
    max_tokens_per_vote=0,  # Maximum amount of incentives to be used per round (Hidden Hands V2)
    periods=1,  # Rounds to be covered by the incentives deposited (Hidden Hands V2)
    badger_bribe_in_liquis=2000,  # NOTE: dollar denominated. Badger calculation is done internaly, the incentive gets process via Paladin
    duration_paladin_quest=1,  # Duration (in number of periods) of the Quest
    reward_per_vote_liquis=0.001,  # Amount of reward per vlLIQ
    liquis_incentive_in_paladin=True,  # Indicates if the incentive is going to be post in paladin or HH
    is_governance_incentive_token=False,  # Indicates if the incentive is going to be governance token ($badger) or different. Applicable only in Paladin.
    aura_proposal_id=None,
    convex_proposal_id=None,

NOTE: currently the minRewardPerVotePerToken is .0025 and we requested to paladin to decrease it to .001 similar to tokens rates like $grai etc. waiting on that to be fully updated onchain to use this script

NOTE: got informed by paladin that addys were updated and new contract was in place with min rates updates across the board for tokens, which i verified. script now is on good state using v2 quest sc for velit/vlliq. in our particular case, i had isolated only to incentive vlliq

Copy link
Collaborator

@sajanrajdev sajanrajdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

  • Confirmed new quest board has a 4500000000000 minRewardPerVotePerToken for BADGER instead of the 200000000000000 of the old one.
  • Introduces the ability to incentivize using LIQ (when governance incentive token flag is set to False, LIquis is used instead with the same amount given).
  • NOTE: LIQ's minRewardPerVotePerToken is 300000000000000 in the new quest board contract (confirmed it is configured and allowed).
  • Adapts the call of the quest creation to the new function signature of the new Quest board and the ability to use BADGER or LIQ
  • Isolates the quest just to vlLIQ voters (as requestd by Liquis) by setting the voterList to only the Liquis Voter Proxy - LG
  • Confirm vote type as whitelisting enum QuestVoteType { NORMAL, BLACKLIST, WHITELIST } -> Allows for limiting to vlLIQ voters
  • Confirm close type as rollover enum QuestCloseType { NORMAL, ROLLOVER, DISTRIBUTE } (undistributed rewards are added to the next period, increasing the reward/vote parameter) - LG

LGTM

Copy link

@rayeaster rayeaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to adapt to new Paladin questboard interface

@sajanrajdev sajanrajdev merged commit ef0f828 into main Jan 18, 2024
3 checks passed
@sajanrajdev sajanrajdev deleted the feat/liquis-incentives branch January 18, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incentives: include $liquis as an incentive token for paladin marketplace
3 participants