feat: add tests after ownership is transfer to assert behaviours #1395
Conversation
This reverts commit 535cc3f.
There was a problem hiding this comment.
Tests showed that all governance functions will be executable from the Timelock and that the BADGER token will remain fully functional (as expected).
NOTE: The BADGER minting processes will require two separate timelock operations:
- Minting
- Transfering the minted tokens out of the Timelock and into their destination
CC @dapp-whisperer, Petro has now pushed the tests for this operation as per your request. Please take a look and note the above.
|
These tests revealed the need for a redesign of the approach as the Timelock would now become the recipient of any minted BADGER which isn't an intended behavior. Nevertheless, there is value on preserving these tests and I would say we move for a merge of them. @rayeaster, would you mind taking a look? |
| tl_gov = accounts.at(r.governance_timelock, force=True) | ||
|
|
||
| # mint | ||
| controller.mint(100e18, {"from": tl_gov}) |
There was a problem hiding this comment.
could use a variable to hold the magic value of 100e18
|
|
||
| badger.transfer(holder_two, 5e18, {"from": holder_one}) | ||
|
|
||
| assert badger.balanceOf(holder_two) == holder_two_bal_before + 5e18 |
There was a problem hiding this comment.
could use a variable to hold the magic value of 5e18
| ["address", "uint256"], | ||
| [safe.address, int(100e18)], | ||
| ) | ||
| eta = chain.time() + int(3 * 60 * 60 * 24) |
There was a problem hiding this comment.
could use a variable to hold the magic value of 3 * 60 * 60 * 24
|
Good comments with regards the magic values @rayeaster. Given that these tests are more informative at this point and the operation is not planned anymore, I will go ahead and merge as is. |
Tackles latest reccoms in #1277