-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TypeScript #15826
base: master
Are you sure you want to change the base?
Update TypeScript #15826
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Reviewer - this PR has made changes to one or more package.json files. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15826/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15826/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15826/merge#BCU1XR#0 |
Is ElementInternals support wide enough considering where the viewer might be used ? |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
Wer usually fix these first by adding them manually to the mixins file and then removing them when not needed. Using an API that only exists in a certain typescript version will also force our users to use this version. Otherwise, type check will fail. |
Yes I think it is ok. If they are missing in a browser, it will just mean annotation elements don't get a reduced opacity when not facing the camera. |
I remembered this from one of our previous conversations :) In this case, it is only used as an implementation detail, it is not surfaced through the API at all, so it doesn't show up in the d.ts files. I believe that means it cannot impact consumers of the package. |
One of my other PRs is failing in the build because the older version of TS we are using (5.1.6) is missing the
states
property from theElementInternals
WebAPI type (thestates
property and the its typeCustomStateSet
are sort of new but supported in all the major browsers). TypeScript 5.5+ has this property and type, so I started trying to update our TypeScript version. However I ran into some problems with deprecated TypeScript APIs used for the path transformation stuff in the build. I tried to fix it (based on some input from the TypeScript team!), but I definitely broke it. So I'm creating a draft PR as a starting point for getting TypeScript updated.