Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf regression Workaround #15817

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Perf regression Workaround #15817

wants to merge 6 commits into from

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Nov 14, 2024

Repro playground: https://playground.babylonjs.com/#9YB6SB

Runs at about 15 fps on first run, plays back at 60 fps when playing a second time

The current "workaround" makes it run at 60 fps on the first run as well. Duplicating the class Vector4 with another name worked as well as using another Temporary Vector4 🤯

This might be a wrong deopt code ???

@sebavan sebavan marked this pull request as draft November 14, 2024 01:05
@sebavan sebavan changed the title Perf reg Perf regression Workaround Nov 14, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants