Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync with WGPU 0.20. #601

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Conversation

John-Nagle
Copy link
Contributor

Checklist

  • CI Checked:
    • cargo fmt has been ran
    • cargo clippy reports no issues
    • cargo test succeeds
    • cargo rend3-doc has no warnings
    • cargo deny check issues have been fixed or added to deny.toml
  • Manually Checked:
    • [x ] relevant examples/test cases run
    • [x ] changes added to changelog
      • Add credit to yourself for each change: Added new functionality @githubname.

Related Issues

Description

Bring Rend3 up to date with current wgpu (0.20), egui, and winit.

Fix outstanding warning messages.

Advance version to 0.20.0 to match wgpu. Intent is to follow wgpu version from now on when possible. After testing, this version should be pushed to "crates.io" as version 0.20.0.

@John-Nagle
Copy link
Contributor Author

Fixing minor problems.

The default scene render test does not match the exemplar image when I run "cargo test" locally, with the reference images loaded. This appeared after I converted everything to use the current "image" crate. The "Bistro" scene does pass.

screenshot Exemplar

screenshot-failure As rendered.

screenshot-diff Diff.

That diff is not totally black. Bring it into an image editor and expand the black out to a wider range of intensities.

    Image Comparison Results
    Expected Mean (0.028385) to be under expected maximum (0.01): FAIL

    Mean: 0.028384654
     Min: 0
     25%: 0.029385423
     50%: 0.039566796
     75%: 0.049417663
     95%: 0.065355726
     99%: 0.076764226
     Max: 0.28033736
    Failed!

@John-Nagle
Copy link
Contributor Author

Diff, black range expanded:

screenshot-diff-expand

There are differences, but they're down near the noise threshold. Real bug, or routine difference?

@John-Nagle
Copy link
Contributor Author

Can I trigger the CI cycle myself, or does someone else have to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant