Author #66
Merged
Author #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added init_data sync_data write_data load_data. Fucntions are the same for Mock and QuadsNative. The fucntions are just copies from libquads.py.
Changed only libquads.py so that now it uses our inventory_service class methods. Added load_data call and changed init_data, write_data, sync_state bodies so that now they call corresponding inventory_service class methods.
These append's were outdated. We don't use them anymore.
I added hilapi.py. This is a library to do REST calls to HIL with error checking, argument checking, error handling. The file hil.yml is necessary to store HIL server IP address. For now, we have this REST call functions in a stand alone file. This is a temporary solution. Opinion of mentors is necessary to decide what is the best place to keep this REST call wrappers. Later on we can easily delete these files and move code from these files elsewhere.
Added init_data sync_data write_data load_data. Fucntions are the same for Mock and QuadsNative. The fucntions are just copies from libquads.py.
Changed only libquads.py so that now it uses our inventory_service class methods. Added load_data call and changed init_data, write_data, sync_state bodies so that now they call corresponding inventory_service class methods.
These append's were outdated. We don't use them anymore.
I added hilapi.py. This is a library to do REST calls to HIL with error checking, argument checking, error handling. The file hil.yml is necessary to store HIL server IP address. We would need this library to implement move_hosts.
As Peter suggested I moved this file to util. Also, changed for we load HIL url. Feel free to change some functions to Isaac's version if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just corrected the author on my last PRs.
@portante Could you check I did this right.
I did
git rebase -i
git commit --amend --author="..." --no-edit