Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockInventoryDriver.py QuadsNativeInventoryDriver.py functions #53

Closed
wants to merge 5 commits into from

Conversation

vsemp
Copy link

@vsemp vsemp commented Apr 16, 2017

Added init_data sync_data write_data load_data. Fucntions are the same for Mock and QuadsNative. The fucntions are just copies from libquads.py.

Added init_data sync_data write_data load_data. Fucntions are the same for Mock and QuadsNative. The fucntions are just copies from libquads.py.
@vsemp vsemp requested a review from portante April 16, 2017 23:25
System Administrator added 3 commits April 16, 2017 19:34
Changed only libquads.py so that now it uses our inventory_service class methods. Added load_data call and changed init_data, write_data, sync_state bodies so that now they call corresponding inventory_service class methods.
I added hilapi.py. This is a library to do REST calls to HIL with error checking, argument checking, error handling. The file hil.yml is necessary to store HIL server IP address.

For now, we have this REST call functions in a stand alone file. This is a temporary solution. Opinion of mentors is necessary to decide what is the best place to keep this REST call wrappers. Later on we can easily delete these files and move code from these files elsewhere.
These append's were outdated. We don't use them anymore.
@@ -0,0 +1,2 @@
url: http://127.0.0.1:5000 # the address of HIL server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsemp see #54
as we discussed prior, I added this as a parameter to conf/quads.yml

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We discussed that. And I agreed with you. But I don't see it added.

So can we merge this first and then we can move this line anywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def show_node(node):
url = make_url('node', node)
return do_get(url)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsemp see #54

def show_node(node):
url = make_url('node', node)
return do_get(url)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsemp see #54

@saacg
Copy link
Member

saacg commented Apr 17, 2017

@vsemp did you test your changes before making this pr? I just cloned the branch and have not been able to get any commands to work without throwing errors when using QuadsNative or Mock as the hardware service.

The bug was due to incorrect arguments in load_data nad write_data in libquads.py. That's why Quads didn't work.
@portante
Copy link
Member

@vsemp, when you rebase these changes on top of class/master, please be sure to setup your git Identity, as described at Git - First Time Git Setup. Most of your changes are committed with their authorship of the system administrator.

Also, please rebase onto class/master following the procedure detailed in the document I created, entitled "Git Rebase Workflow".

@vsemp vsemp closed this Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants