Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration] Adding ART to the benchmark #38

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Integration] Adding ART to the benchmark #38

wants to merge 5 commits into from

Conversation

ramananeesh
Copy link
Collaborator

@ramananeesh ramananeesh commented Oct 3, 2024 •
edited
Loading

This PR integrates the Adaptive Radix Tree [Leis, et.al.] into the BLISS benchmark.

Added Functionality:

  • Imports an internal BU-DiSC fork of ART as a CMake library
  • Adds corresponding adapters for integration
  • Adds unit tests for basic sanity check, similar to other indexes

Modified files:

  • CMakeLists.txt
  • external/CMakeLists.txt
  • src/bliss_bench.cpp
  • tests/CMakeLists.txt
  • tests/bliss_index_tests.h
  • .gitignore

@ramananeesh ramananeesh requested a review from ephoris October 3, 2024 14:33
@ramananeesh ramananeesh added the enhancement New feature or request label Oct 3, 2024
@ramananeesh ramananeesh marked this pull request as ready for review October 3, 2024 14:34
ephoris
ephoris approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@ephoris ephoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just remove some of the dead comments and we're good.

src/bliss/util/execute.h Outdated Show resolved Hide resolved
ramananeesh
ramananeesh commented Nov 13, 2024
View reviewed changes
Copy link
Collaborator Author

@ramananeesh ramananeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JslYoon JslYoon JslYoon left review comments

@ephoris ephoris ephoris approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@JslYoon JslYoon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramananeesh @ephoris @JslYoon