[Features] Integrating ART #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add radix tree benchmark
|
Can you add back the |
JslYoon
force-pushed
the
features/ART
branch
from
5c3110a to
1eb0c97
Compare
Just added back! |
Closed
ramananeesh
requested changes
Sep 23, 2024
ramananeesh
requested changes
Sep 25, 2024
ramananeesh
requested changes
Sep 26, 2024
src/bliss/bench_ART.h
Outdated
| ART::loadKey(key, ARTkey); | ||
|
|
||
| uint8_t depth = 0; | ||
| ART::insert(_index, &_index, ARTkey, depth, value, KEY_SIZE); |
There was a problem hiding this comment.
@JslYoon why is this trying to insert value with size equivalent to KEY_SIZE? Remember KEY_SIZE != VALUE_SIZE always, it just so happens to be the case for our current set of experiments!
* [Refactor] moved util code to separate header files * [FEAT] added unit tests * Added detailed instructions on integrating new index to readme * minor refactor to define * minor refactor to header defs
* Create cmake-single-platform.yml for Github actions workflow * Update cmake-single-platform.yml * added a verifier to check if unit tests exist * minor edit * minor edit
|
I am closing this PR - will be creating a new one for this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ART index for Bliss benchmark