Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished Hierotek Circle for KT 24 #898

Merged
merged 29 commits into from
Oct 17, 2024
Merged

Conversation

mhelvin505
Copy link
Collaborator

@mhelvin505 mhelvin505 commented Oct 15, 2024

I finished updating Hierotek Circle for the new edition. Feel free to let me know if there is anything I need to fix as this is my first time working with this project.

pinedm3 and others added 27 commits October 14, 2024 09:34
@mal20k
Copy link
Collaborator

mal20k commented Oct 15, 2024

Thanks for doing this! A few changes:
Style

  • In the Force Entry, swap from "X selections in parent" to "X selections in force" for consistency.
  • Reanimator and Accelerator can have an "exactly 1 selections in force" constraint on their root selection entry which will auto-add them to the list. This will also apply automagically to Rosters.
  • Rule, ability, unique action, and equipment descriptions should remove the extra newlines that cut off the sentences and just let it flow if it's not actually a new paragraph.
  • VERY minor nit: Move the * on the magnify rule to the front. In the book it's on the right for the weapon profile and then left for the actual rule. You also don't need it in both Root Rules and Shared Rules, just the Shared is fine.
  • Swap out any dots for - since NewRecruit can format using markdown and that's a list in markdown.
  • Instances where a weapon doesn't have any weapon rules should have a - instead of being left blank.
  • Weapons with separate profiles should have the part in parenthesis added even if it's a melee/ranged version of it. Just consistency with the book. (e.g. Aeonstave)
  • Try not to have conditions on shared selection entries themselves, such as the Claws for the Plasmacytes. Sometimes there are shared items that have different inclusion requirements based on the operative. Conditions can be added onto a link itself and won't affect the linked selection entry.
  • For abilities, equipment, unique actions that grant some weapon rule, splitting it out into a selection entry that contains that weapon rule will make sure the reference is included in the output. For example, Deathmarked can go into a Deathmark Selection Entry that has an "exactly 1 selections in parent" so the granted Seek can be added as a rule link.
  • No need to specify order for things, you can remove the sorting. Nevermind, leave this in!
  • For any Selection Entry Group, change the Default Selection to None. This will generally be the right thing with regards to weapon selection so the team builder forces the selection instead of picking the first one as default.

Data

  • Chronomancer's Entropic Lance (melee) should have no WR
  • Missing Piercing rule link on Psychomancer's Abyssal lance
  • Cryptek actions aren't the same as they were, the Apprentek just references the leader you selected, so no need to duplicate that.
  • Deathmark fists are 3/4

@mal20k
Copy link
Collaborator

mal20k commented Oct 17, 2024

I've got some changes, but I'll make them in my branch. Thanks for this!

@mal20k mal20k merged commit 8a38d11 into BSData:kt2024-beta Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants