Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #897: Update versions of GHA's #896

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

alerickson0
Copy link
Contributor

Updating the version of GHA's being used. One reason is to address security concerns.

Copy link
Collaborator

@mal20k mal20k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this! A few things to change, but otherwise looks good!

Comment on lines 5 to 7
# schedule:
# - cron: 0 0 1 * * # Every 1st day of the month at 0000 – https://crontab.guru
workflow_dispatch:
Copy link
Collaborator

@mal20k mal20k Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the monthly release issue for the bot, so we need it on a schedule of the first of the month. Removing the cron job is not what we want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll set it back to scheduled. I was just trying to test out my changes first before submitting

Comment on lines 21 to 22
run: |
release_thread_date="$(date +'%B %Y')"
echo "date=$release_thread_date" >> $GITHUB_OUTPUT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This can just be simplified as

echo "date=$(date +'%B %Y')" >> $GITHUB_OUTPUT

@alerickson0 alerickson0 force-pushed the ae-update-ghas branch 2 times, most recently from 58edf0d to 6c157b5 Compare October 2, 2024 23:09
Updating the version of GHA's being used. One reason is to address
security concerns.
@mal20k mal20k changed the title ci: Update versions of GHA's fixes #897: Update versions of GHA's Oct 2, 2024
@mal20k mal20k merged commit 044d7f7 into BSData:master Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants