Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blackshields gaining white scars movement buff #3266

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

nstephenh
Copy link
Contributor

@nstephenh nstephenh commented Jun 14, 2024

This should fix #3218
Automated with bscopy, because I'd rather spend twice as long automating it then to do it by hand:
https://github.com/nstephenh/BSCopy/blob/main/find_conditions.py

There are 1122 modifiers using those conditions
20 modifiers already reference blackshields
1102 need review
89 of those appear to be whitescars movement

@nstephenh nstephenh requested a review from The4D6 June 14, 2024 19:29
@nstephenh
Copy link
Contributor Author

That last commit got the last 4 movement modifiers I believe:
There are 1122 modifiers using those conditions
105 modifiers already reference blackshields
1017 need review
4 of those appear to be whitescars movement
4 conditions updated this run

@nstephenh nstephenh linked an issue Jul 2, 2024 that may be closed by this pull request
@nstephenh nstephenh changed the base branch from even-more-fixes-19.1 to main July 2, 2024 18:19
@nstephenh nstephenh force-pushed the fix-blackshield-conditions branch from fc2b5ce to 0c2542f Compare July 2, 2024 18:21
@nstephenh nstephenh changed the title Fix blackshield conditions Fix blackshields gaining white scars movement buff Jul 2, 2024
@nstephenh
Copy link
Contributor Author

Merging this since it shouldn't cause any issues.

@nstephenh nstephenh merged commit 9018cbe into main Jul 2, 2024
2 checks passed
@nstephenh nstephenh deleted the fix-blackshield-conditions branch July 2, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blackshields gaining White Scars movement buff
1 participant