[WIP] Adeptus Astartes upgrade from "Horus Heresy - Rulebook"

[davidmunoznovoa]

Fixes #106

Tasks

• Create Legion-Specific Upgrades
  • Loyalist Legions
    • Dark Angels: Ravenwing Veteran
    • White Scars: Swift of Wing
    • Space Wolves: Peerless Hunter
    • Imperial Fists: Aegis Pilot
    • Blood Angels: Master of the Skies
    • Iron Hands: Iron Father
    • Ultramarines: Alaris Pilot
    • Salamanders: Tempered Plating
    • Raven Guard: Shadow Bird
  • Traitor Legions
    • Emperor's Children: Phoenix Pilot
    • Iron Warriors: Hullbreaker Missiles
    • Night Lords: Anguish Engines
    • World Eaters: Red Hunter
    • Death Guard: Shroud of Barbarus
    • Thousand Sons: Corvidae Initiate
    • Sons of Horus: Warmaster's Chosen
    • Word Bearers Possessed Pilot
    • Alpha Legion: Sacii Pilot
• Show Legion-Specific Upgrades in compatible aircrafts
  • Fighters
    • Xiphon Interceptor
    • Storm Eagle Assault Craft
    • Fire Raptor Gunship
  • Bombers
    • Thunderhawk Gunship
• Implement constraints in upgrade selection
  • Unable to select upgrades from both Traitor and Loyalist allegiances in the same force.
  • Unable to select distinct Legion-Specific upgrades in the same force.
  • Unable to select more than once the "1 per force" upgrades in the same force.
  • Incompatible upgrades:
    • Dark Angels: Revenwing Veteran with Veteran and viceversa.
    • Salamanders: Tempered Plating with Ceramite Plating and viceversa.
    • Iron Father with Techmarine and viceversa.
• Increment revision in data file

Pending Issues

• Implement constraints in upgrade selection

  • Unable to select more than 2 upgrades for an aircraft

• Implement checkbox to use or not "Horus Heresy rules"

  • Marking the checkbox must hide and restrict incompatible aircrafts and Ground Assets:
    • Dark Fire
    • The Unkillable Phantom
    • Icarus Stormcannon Array
  • Marking the checkbox must show and make available new aircrafts and Ground Assets:
    • Ares Gunship (inheriting this aircraft profile on a future new data file exclusively for Custodes)
    • Daedalus Stormcannon (replaces Icarus Stormcannon Array with same characteristics except the name)
  • Mark/Unmark the checkbox must show/hide respectively the Legion-Specific upgrades and also allow/restrict their use respectively.

Requirements update

• Upgraded Github Actions to v4, because v1 and v2 are deprecated.

Screenshots

[davidmunoznovoa]

@evanh I don't know if you are still supervising the repository and its pull-requests. I haven't had time these past few months to get back to work and finish the missing points (limiting the number of improvements to 2 and enabling/disabling the use of Horus Heresy profiles). Do you think it's worth merging or should I close the PR? It took me a few hours, but nothing that someone with more experience and fluency couldn't reproduce better and faster.

[evanh]

I think you've already done the work, I'm happy to merge/deploy when you're ready.

[davidmunoznovoa]

I think you've already done the work, I'm happy to merge/deploy when you're ready.

Thank you very much. We can merge, then. It's been an honour to collaborate a little. :)

[davidmunoznovoa]

@evanh It seems PR is unable to be merged because of some dependencies in validations. ¯\_(ツ)_/¯

[davidmunoznovoa]

@evanh Can you do the merge, please? I've upgraded GithubActions to "v4" in workflows, so tests now pass, but I don't have write access to do the merge by myself.