Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto join 1:1 relations #249

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

frida-161
Copy link
Contributor

This PR implements the Auto Join of 1:1 relations as described in Issue #248

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #249 (1e03947) into master (84de3da) will decrease coverage by 0.05%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   19.12%   19.06%   -0.06%     
==========================================
  Files          42       42              
  Lines        3708     3724      +16     
  Branches      610      560      -50     
==========================================
+ Hits          709      710       +1     
- Misses       2947     2960      +13     
- Partials       52       54       +2     
Impacted Files Coverage Δ
...plication_schema_toolbox/gui/import_gmlas_panel.py 0.00% <0.00%> (ø)
...lication_schema_toolbox/core/load_gmlas_in_qgis.py 75.39% <16.66%> (-6.33%) ⬇️

@frida-161
Copy link
Contributor Author

@Guts Do you think we could get this feature merged?

@Guts Guts self-assigned this Nov 9, 2022
@kannes
Copy link

kannes commented Feb 9, 2023

I'd suggest a tiny change to the option label: "Automatically join 1:1 relation tables" or something similar to make it more clear what this option does. There is enough space.

@frida-161
Copy link
Contributor Author

I'd suggest a tiny change to the option label: "Automatically join 1:1 relation tables" or something similar to make it more clear what this option does. There is enough space.

Thanks for the suggestions. Now its much clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants