add password options + fix password prompts #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
previously approved these changes
Jan 18, 2024
src/bin/btc-hot.rs
Outdated
| if let Some(pass) = password_arg.clone() { | ||
| Ok(pass) | ||
| } else { | ||
| print!("{prompt}: "); |
There was a problem hiding this comment.
I think it should be eprint not to mix with the output of the actual program
There was a problem hiding this comment.
The reason I used print! was to keep the previous behavior unchanged.
Using eprint! makes sense to me, though, as the prompts would be visible to the user even when stdout has been redirected.
Updated.
|
Very good improvement, thank you! Let me know what do you think about my comment, otherwise LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes password prompts, which were did not appear on the console, and adds options for
btc-hotto provide passwords directly from the command line (for unattended usage).