Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API improvements for v0.11 #68

Merged
merged 24 commits into from
Dec 25, 2023
Merged

API improvements for v0.11 #68

merged 24 commits into from
Dec 25, 2023

Conversation

dr-orlovsky
Copy link
Member

These are small API changes which were required during the current work on RGB standard library v0.11

cryptoquick
cryptoquick previously approved these changes Dec 14, 2023
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 119 lines in your changes are missing coverage. Please review.

Comparison is base (aacb019) 49.5% compared to head (4f93149) 48.8%.

❗ Current head 4f93149 differs from pull request most recent head 3ad4349. Consider uploading reports for the commit 3ad4349 to get more accurate results

Files Patch % Lines
dbc/src/opret/spk.rs 0.0% 22 Missing ⚠️
consensus/src/coding.rs 0.0% 19 Missing ⚠️
dbc/src/opret/tx.rs 0.0% 19 Missing ⚠️
dbc/src/anchor.rs 0.0% 18 Missing ⚠️
dbc/src/opret/txout.rs 0.0% 11 Missing ⚠️
consensus/src/tx.rs 0.0% 9 Missing ⚠️
dbc/src/opret/mod.rs 25.0% 6 Missing ⚠️
dbc/src/tapret/xonlypk.rs 66.7% 4 Missing ⚠️
consensus/src/script.rs 0.0% 3 Missing ⚠️
dbc/src/tapret/mod.rs 0.0% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #68     +/-   ##
========================================
- Coverage    49.5%   48.8%   -0.7%     
========================================
  Files          29      34      +5     
  Lines        3070    3123     +53     
========================================
+ Hits         1520    1525      +5     
- Misses       1550    1598     +48     
Flag Coverage Δ
rust 48.8% <18.5%> (-0.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky merged commit 801a162 into master Dec 25, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants