Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing abilities: adding necessary types and logic to consensus #101

Merged
merged 20 commits into from
Jul 17, 2024

Conversation

dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky added the enhancement New feature or request label Jun 29, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Jun 29, 2024
@dr-orlovsky dr-orlovsky self-assigned this Jun 29, 2024
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 1.53173% with 450 lines in your changes missing coverage. Please review.

Project coverage is 41.7%. Comparing base (12931d1) to head (23bc44c).

Files Patch % Lines
consensus/src/sigcache.rs 0.0% 311 Missing ⚠️
consensus/src/taproot.rs 3.0% 65 Missing ⚠️
consensus/src/sigtypes.rs 0.0% 32 Missing ⚠️
consensus/src/coding.rs 7.7% 24 Missing ⚠️
consensus/src/script.rs 5.3% 18 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #101     +/-   ##
========================================
- Coverage    47.5%   41.7%   -5.8%     
========================================
  Files          34      35      +1     
  Lines        3174    3618    +444     
========================================
  Hits         1508    1508             
- Misses       1666    2110    +444     
Flag Coverage Δ
rust 41.7% <1.5%> (-5.8%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 23bc44c

@dr-orlovsky dr-orlovsky merged commit 1989b57 into master Jul 17, 2024
19 of 20 checks passed
@dr-orlovsky dr-orlovsky deleted the signer branch September 4, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants