Docker wrapper: always mount slot dir at WORKDIR #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that the tree rooted at WORKDIR is on the host filesystem, and therefore survives system restarts; otherwise it wouldn't. This also simplifies file access from containers. There's no need to copy input files from the slot dir to the container; they're already in the container. Similar with output files. Remove these capabilities from the wrapper. If a Docker app wants to access files in the project dir (e.g. if they're huge files, shared with other jobs) it can do so by mounting the project dir (using job.toml) and then parsing the link files. Merge the two test cases (copy and mount) into one in both standalone and app_test.
Docker chokes on the Windows-style "c:\blah..." path
AenBleidd
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that the tree rooted at WORKDIR is on the host filesystem,
and therefore survives system restarts;
otherwise it wouldn't.
This also simplifies file access from containers.
There's no need to copy input files from the slot dir to the container;
they're already in the container.
Similar with output files.
Remove these capabilities from the wrapper.
If a Docker app wants to access files in the project dir
(e.g. if they're huge files, shared with other jobs)
it can do so by mounting the project dir (using job.toml)
and then parsing the link files.
Merge the two test cases (copy and mount) into one
in both standalone and app_test.
Fixes #5882