Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised heartbeat check #5864

Merged

Conversation

computezrmle
Copy link
Contributor

Volunteers from LHC@home often report issues (false positives) in connection with the heartbeat file detection.
In most cases it affects Windows hosts.

This PR introduces a revised heartbeat file handling and a slightly modified reporting.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.83%. Comparing base (d344bf9) to head (b7f2616).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #5864      +/-   ##
===========================================
- Coverage     10.76%   9.83%   -0.94%     
  Complexity     1068    1068              
===========================================
  Files           280     280              
  Lines         36494   36310     -184     
  Branches       8444    8444              
===========================================
- Hits           3930    3571     -359     
- Misses        32175   32196      +21     
- Partials        389     543     +154     

see 12 files with indirect coverage changes

@AenBleidd AenBleidd added this to the vboxwrapper v26208 milestone Oct 28, 2024
@AenBleidd AenBleidd merged commit 592e9c4 into BOINC:master Oct 28, 2024
146 checks passed
@computezrmle computezrmle deleted the computezrmle_revised_heartbeat_check branch October 29, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants