Make wrappers work with sporadic apps #5410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sporadic state via files. This allows, for example, sporadic VM apps. The logic for reading and writing of files is in the API library, rather than in the wrappers. Also: wrappers show message and exit if bad command line option. Also: small code shuffle in vboxwrapper to parse cmdline before doing anything.
API: debug sporadic stuff.
Remove 2-second exit delay in standalone mode.
client:
if <heartbeat_debug>, show the heartbeat message
don't create slot dir for --app_test job (it uses slots/app_test)
don't show sporadic resoures used if there are none
sporadic:
add --wrapped option: don't use BOINC api; communicate via files
wrapper:
don't print start msg twice
AenBleidd
approved these changes
Oct 27, 2023
| @@ -63,9 +63,11 @@ void CLIENT_STATE::app_test_init() { | |||
| // can put other stuff here like | |||
| av->avg_ncpus = 1; | |||
| av->flops = 1e9; | |||
| #if 0 | |||
There was a problem hiding this comment.
Is this changed by intention?
|
@davidpanderson, build failed for OSX, please fix: |
AenBleidd
approved these changes
Oct 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5410 +/- ##
============================================
- Coverage 10.85% 10.84% -0.02%
Complexity 1068 1068
============================================
Files 279 279
Lines 36114 36157 +43
Branches 8344 8355 +11
============================================
Hits 3920 3920
- Misses 31800 31843 +43
Partials 394 394
|
AenBleidd
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --sporadic option to wrapper and vboxwrapper.
When used, the wrapper communicates sporadic state with the app via files.
This allows, for example, sporadic apps that run in VMs.
The logic for reading/writing these files is in the BOINC runtime library;
to enable it, the wrapper calls boinc_sporadic_dir().
So changes to the wrappers is minimal.