Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Increase Target SDK Version API to 28. #5344

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

AenBleidd
Copy link
Member

Most of the breaking changes from API 21 to API 28 were made in a way that it doesn't really matter which API your applications targets. That is why there is no risk by increasing API level to 28. This will remove the message about outdated application, and also will remove an issue with the newer phones that have 4k display. It's not possible to increase it further, because starting from API 29 W^X feature was introduced, and this prevent us from running any executable that is not the part of our APK (even the client that we are copying from the assets folder based on the current device architecture).

Most of the breaking changes from API 21 to API 28 were made in a way that it doesn't really matter which API your applications targets.
That is why there is no risk by increasing API level to 28.
This will remove the message about outdated application, and also will remove an issue with the newer phones that have 4k display.
It's not possible to increase it further, because starting from API 29 W^X feature was introduced, and this prevent us from running any executable that is not the part of our APK (even the client that we are copying from the assets folder based on the current device architecture).

Signed-off-by: Vitalii Koshura <[email protected]>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #5344 (2825e35) into master (b8f67dc) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5344      +/-   ##
============================================
- Coverage     10.87%   10.87%   -0.01%     
  Complexity     1068     1068              
============================================
  Files           279      279              
  Lines         36058    36059       +1     
  Branches       8334     8335       +1     
============================================
  Hits           3920     3920              
- Misses        31744    31745       +1     
  Partials        394      394              

see 1 file with indirect coverage changes

@AenBleidd AenBleidd merged commit a490b80 into BOINC:master Aug 22, 2023
48 checks passed
@AenBleidd AenBleidd deleted the vko_android_increase_api_to_28 branch August 22, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant