Scheduler: add <min_libc_version> option to plan_class_spec.xml #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Linux) If you build an app on a machine with a given version of libc, it won't run on hosts with older versions. Until now you had to build on a super-old system. With this change you can build on a newer system, and give the app version a plan class that limits it to hosts with that min libc version.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5323 +/- ##
============================================
- Coverage 10.86% 10.85% -0.01%
Complexity 1064 1064
============================================
Files 279 279
Lines 35991 36005 +14
Branches 8320 8326 +6
============================================
Hits 3909 3909
- Misses 31690 31704 +14
Partials 392 392
|
AenBleidd
approved these changes
Aug 10, 2023
|
Looks good to me. Thank you for the feature implementation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Linux) If you build an app on a machine with a given version of libc, it won't run on hosts with older versions.
Until now you had to build on a super-old system.
With this change you can build on a newer system,
and give the app version a plan class that limits it to hosts with that min libc version.