-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Gen steps #93
base: main
Are you sure you want to change the base?
Conversation
…rocess parameters at genstepp creation. Added a new gdml for this. For now values are kinda random...
} | ||
|
||
void AddOpticksHits() | ||
{ | ||
SEvt *sev = SEvt::Get_ECPU(); | ||
SEvt *sev = SEvt::Get_EGPU(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggalgoczi Why did you change this line? When I make this change I get an error. See #94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replied this just now in the other tag.
@@ -521,6 +556,7 @@ struct G4App | |||
G4VUserDetectorConstruction *det_cons_; | |||
G4VUserPrimaryGeneratorAction *prim_gen_; | |||
EventAction *event_act_; | |||
RunAction *run_act_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to add a RunAction? I see that you access Opticks hits in RunAction::EndOfRunAction()
, but why can't we do the same in EventAction::EndOfEventAction()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to run Opticks with a lot of photons. Since in our events we will have few hundred photons then if we run Opticks after each Event we will have a slowdown of a factor of ~10-100x.
Regarding #94 I will reply there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this sounds more like an optimization than a necessity at the moment. Our first priority should be to access GPU hits at the end of each event.
No description provided.