Torch test #78
Closed
Torch test #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added environment variables used for torch.
emphasize that primary photon number is set by environment variable too
|
This PR introduces many changes and completely rewrites the current logic. It might be better to reorganize the code by introducing a switch between the existing and the new logic, or simply create a new file that can be developed in parallel to g4app.h |
|
We can create a new file instead of g4app.h I will do that once I clear issues with higher priority. Closing this PR then. The discrepancy between G4 and Opticks hits was solved since then in |
|
Okay... So, do I understand correctly, that all we need is to change REFLECTIVITY in the gdml geometry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A branch for testing the "torch" photon generation without saving photons and reading them in.
By running the commands in the readme file I get the following results:
PhotonSD::EndOfEvent Number of PhotonHits: 22
Opticks: NumCollected: 1
Opticks: NumCollected: 100
Opticks: NumHits: 25
One can see that there are Opticks and G4 Hits too.