Torch test #77
Closed
Torch test #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added environment variables used for torch.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v12.0.1
Only 6 out of 7 clang-format concerns fit within this pull request's diff.
Click here for the full clang-format patch
diff --git a/src/g4app.h b/src/g4app.h
index 69eb8fc..68e03ac 100644
--- a/src/g4app.h
+++ b/src/g4app.h
@@ -28,0 +29 @@
+#include "SysRap/SGenerate.h"
@@ -36,2 +36,0 @@
-#include "SysRap/SEvt.hh"
-#include "SysRap/SGenerate.h"
@@ -40 +38,0 @@
-
@@ -287,3 +285,3 @@ struct PrimaryGenerator : G4VUserPrimaryGeneratorAction
- int idx_arg = event->GetEventID() ;
- NP* gs = SEvent::MakeTorchGenstep(idx_arg) ;
- NP* ph = SGenerate::GeneratePhotons(gs);
+ int idx_arg = event->GetEventID();
+ NP *gs = SEvent::MakeTorchGenstep(idx_arg);
+ NP *ph = SGenerate::GeneratePhotons(gs);
@@ -291 +289 @@ struct PrimaryGenerator : G4VUserPrimaryGeneratorAction
- delete ph ;
+ delete ph;
@@ -315,2 +313,2 @@ struct EventAction : G4UserEventAction
- gx->simulate(eventID, false);
- cudaDeviceSynchronize();
+ gx->simulate(eventID, false);
+ cudaDeviceSynchronize();
@@ -354,2 +352,2 @@ struct SteppingAction : G4UserSteppingAction
- }
- };
+ }
+};
Have any feedback or feature suggestions? Share it here.
src/g4app.h
Outdated
Comment on lines
36
to
37
| #include "SysRap/SEvt.hh" | ||
| #include "SysRap/SGenerate.h" |
There was a problem hiding this comment.
clang-format suggestion
Please remove the line(s)
- 36
- 37
src/g4app.h
Outdated
| #include "SysRap/SEvt.hh" | ||
| #include "SysRap/SGenerate.h" | ||
| #include "U4/U4VPrimaryGenerator.h" | ||
|
|
||
|
|
There was a problem hiding this comment.
clang-format suggestion
Please remove the line(s)
- 40
src/g4app.h
Outdated
Comment on lines
287
to
289
| int idx_arg = event->GetEventID() ; | ||
| NP* gs = SEvent::MakeTorchGenstep(idx_arg) ; | ||
| NP* ph = SGenerate::GeneratePhotons(gs); |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| int idx_arg = event->GetEventID() ; | |
| NP* gs = SEvent::MakeTorchGenstep(idx_arg) ; | |
| NP* ph = SGenerate::GeneratePhotons(gs); | |
| int idx_arg = event->GetEventID(); | |
| NP *gs = SEvent::MakeTorchGenstep(idx_arg); | |
| NP *ph = SGenerate::GeneratePhotons(gs); |
src/g4app.h
Outdated
| NP* gs = SEvent::MakeTorchGenstep(idx_arg) ; | ||
| NP* ph = SGenerate::GeneratePhotons(gs); | ||
| U4VPrimaryGenerator::GeneratePrimaries_From_Photons(event, ph); | ||
| delete ph ; |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| delete ph ; | |
| delete ph; |
src/g4app.h
Outdated
Comment on lines
315
to
316
| gx->simulate(eventID, false); | ||
| cudaDeviceSynchronize(); |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| gx->simulate(eventID, false); | |
| cudaDeviceSynchronize(); | |
| gx->simulate(eventID, false); | |
| cudaDeviceSynchronize(); |
src/g4app.h
Outdated
Comment on lines
354
to
355
| } | ||
| }; |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| } | |
| }; | |
| } | |
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A branch for testing the "torch" photon generation without saving photons and reading them in.
By running the commands in the readme file I get the following results:
PhotonSD::EndOfEvent Number of PhotonHits: 22
Opticks: NumCollected: 1
Opticks: NumCollected: 100
Opticks: NumHits: 25
One can see that there are Opticks and G4 Hits too.