-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argaman learner features refactor 1 #775
Open
amir9979
wants to merge
11
commits into
master
Choose a base branch
from
argaman_learner_features_refactor_1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der to contain the files that contain the features to extract. this need to be run before it is pushed to the master. Signed-off-by: argaman <[email protected]>
moved the commit stuff to another module. made the code cleaner and easier for me to add the ability to add C# content. Signed-off-by: argaman <[email protected]>
… to the current code. I sure hope it'll start working soon :) Signed-off-by: argaman <[email protected]>
…r_1' into argaman_learner_features_refactor_1 # Conflicts: # learner/wekaMethods/articles.py # learner/wekaMethods/articlesOld.py # learner/wekaMethods/buildDB.py
trying to fix and remove some code. trying to untangle the mess that is going in here to create a workflow that actually works and I can understand. Signed-off-by: argaman <[email protected]>
trying to fix and remove some code. trying to untangle the mess that is going in here to create a workflow that actually works and I can understand. Signed-off-by: argaman <[email protected]>
trying to fix and remove some code. trying to untangle the mess that is going in here to create a workflow that actually works and I can understand. Signed-off-by: argaman <[email protected]>
changed some module to be classes. added loggings. fixed some bugs. Signed-off-by: argaman <[email protected]>
changed some module to be classes. added loggings. fixed some bugs. Signed-off-by: argaman <[email protected]>
Signed-off-by: argaman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.