fixing a bug preventing to load an environment when the layout is not…

… correct
BDonnot · Oct 1, 2024 · 4b60e36 · 4b60e36
1 parent df61eaf
commit 4b60e36
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -73,6 +73,8 @@ Next release
 - [FIXED] the `self.skip_if_needed()` was missing for one of the test suite.
 - [FIXED] an error in the descirption of the `educ_case14_storage` environment
   (wrong sign for the slack generator)
+- [FIXED] the environment would not load in case of an incorrect "layout.json"
+  instead of raising a warning.
 - [IMPROVED] error message when forecasts are not correctly set-up
 
 [1.10.3] - 2024-07-12

diff --git a/docs/conf.py b/docs/conf.py
@@ -22,7 +22,7 @@
 author = 'Benjamin Donnot'
 
 # The full version, including alpha/beta/rc tags
-release = '1.10.4.dev0'
+release = '1.10.4.dev1'
 version = '1.10'
 
 

diff --git a/grid2op/MakeEnv/MakeFromPath.py b/grid2op/MakeEnv/MakeFromPath.py
@@ -1046,6 +1046,8 @@ def make_from_dataset_path(
 
     # Set graph layout if not None and not an empty dict
     if graph_layout is not None and graph_layout:
-        env.attach_layout(graph_layout)
-
+        try:
+            env.attach_layout(graph_layout)
+        except EnvError as exc_:
+            warnings.warn(f"Error {exc_} while setting the environment layout.")
     return env
diff --git a/grid2op/__init__.py b/grid2op/__init__.py
@@ -11,7 +11,7 @@
 Grid2Op
 
 """
-__version__ = '1.10.4.dev0'
+__version__ = '1.10.4.dev1'
 
 __all__ = [
     "Action",