Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute Flux Calculation Fix #120

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Absolute Flux Calculation Fix #120

wants to merge 12 commits into from

Conversation

SherelynA
Copy link
Collaborator

Patch to fix absolute flux calculation which is is missing a square.

@SherelynA SherelynA self-assigned this Nov 12, 2024
@hover2pi
Copy link
Member

Let me know if/when you want a review on this!

@SherelynA
Copy link
Collaborator Author

@hover2pi
Yes, I actually wanted to know if you had any nifty idea about how to check these are flux calibrated properly. I currently have some code written for test but nothing that is checking it yet.

@SherelynA SherelynA requested a review from hover2pi November 12, 2024 20:34
@kelle kelle added this to the v2.1 milestone Nov 13, 2024
@kelle kelle mentioned this pull request Nov 15, 2024
Open
@kelle
Copy link
Member

kelle commented Nov 15, 2024

I added some tests and I think this is ready for review.

@SherelynA SherelynA requested a review from kelle November 15, 2024 17:32
hover2pi
hover2pi approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@hover2pi hover2pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for writing these tests!

@hover2pi
Copy link
Member

hover2pi commented Nov 15, 2024 •
edited
Loading

Oh, to answer your question above, we could run this test on a specific source and compare against some values from the literature. That would be great, though I don't think there are any verification tests with actual sources besides Vega. I would say add verification tests in a later PR and merge this now.

@SherelynA
Copy link
Collaborator Author

SherelynA commented Nov 15, 2024 •
edited
Loading

sounds good, I am going to merge! is that good @hover2pi ?

@SherelynA SherelynA requested review from kelle and removed request for kelle November 25, 2024 01:44
@kelle
Copy link
Member

kelle commented Dec 18, 2024

@SherelynA , you can squash and merge this. Once done, I can make a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelle kelle kelle approved these changes

@hover2pi hover2pi hover2pi approved these changes

Assignees

@SherelynA SherelynA

Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@SherelynA @hover2pi @kelle