New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[유저] 학부를 선택해도 반영되지 않는 이슈 #589

Merged

Gwak-Seungju merged 1 commit into develop from fix/#588/no-reflected-major

Nov 25, 2024

Contributor

Gwak-Seungju commented Nov 23, 2024 •

edited

Loading

Close [유저] 학부를 선택해도 설정되지 않는 이슈 #588

What is this PR? 🔍

기능 : 학번을 선택하지 않은 채 학부를 선택하면 반영되지 않는 이슈를 해결했습니다.
issue : [유저] 학부를 선택해도 설정되지 않는 이슈 #588

Changes 📝

학번이 빈 문자열일 시 학부와 함께 빈 값을 반환하는 경우를 없앴습니다.

✔️ Please check if the PR fulfills these requirements

It's submitted to the correct branch, not the develop branch unconditionally?
If on a hotfix branch, ensure it targets main?
There are no warning message when you run yarn lint


          fix: 빈 학번과 상관 없이 major 반환

8bd5faf

Gwak-Seungju added 🐞 BugFix 👤 User labels

Gwak-Seungju self-assigned this

github-actions bot requested review from hoooooony and Yejin0070

November 23, 2024 15:18

hoooooony approved these changes

View reviewed changes

Yejin0070 reviewed

View reviewed changes

Contributor

Yejin0070 left a comment

수고하셨습니다~!!

Gwak-Seungju merged commit 6ad375e into develop

3 checks passed

github-actions bot deleted the fix/#588/no-reflected-major branch

November 25, 2024 14:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 BugFix 👤 User