MNT #287 impose minimum Python version

[prjemian]

• close update minimum Python version for new_bluesky_instrument #287

[coveralls]

Pull Request Test Coverage Report for Build 9456762787

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.08%) to 82.759%

---

Totals
Change from base Build 8883479879:	0.08%
Covered Lines:	984
Relevant Lines:	1189

---

💛 - Coveralls

[prjemian]

I will update the CHANGES.rst file for this PR, too.

[MDecarabas]

Overall looks good. Small comments. Also maybe a docstring will be useful for the file so that future contributors will know what this file is used for. As of right now this is unclear to me.

[MDecarabas]

Is there any reason why this import is not global?

[prjemian]

It is not global so the application does not crash under Python <3.9 with this exception. Instead, the more meaningful message is printed to use Python 3.9 or higher.

Could have put a try..except at the global level...

[prjemian]

I'll rewrite it to the global part.

[MDecarabas]

New commit looks good. If you believe this to be a legitimate worry we will encounter during deployment we can implement this solution so that we have better control over the environment. Especially since the repository comes with an env file.

https://stackoverflow.com/questions/74857446/how-to-specify-python-version-range-in-environment-yml-file

[prjemian]

Not sure we need to put a maximum version. Minimum version for the bluesky environment is specified:

bluesky_training/bluesky/environments/environment_2024_2.yml

Line 30 in 7f2b059

- python >=3.10

This is different than minimum version to run this installer. We'll want this soon since the current installer:

• fails for Python 3.6 and 3.7
• does not install the latest environment file

[MDecarabas]

Same as above

[coveralls]

Pull Request Test Coverage Report for Build 9489045808

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 82.675%

---

Totals
Change from base Build 8883479879:	0.0%
Covered Lines:	983
Relevant Lines:	1189

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9490715430

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 82.675%

---

Totals
Change from base Build 8883479879:	0.0%
Covered Lines:	983
Relevant Lines:	1189

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9490764218

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 82.675%

---

Totals
Change from base Build 8883479879:	0.0%
Covered Lines:	983
Relevant Lines:	1189

---

💛 - Coveralls

[MDecarabas]

Looks good!