move diff_check to tools folder

BBBmau · Feb 16, 2024 · 25819d8 · 25819d8
1 parent a9e631f
commit 25819d8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/.github/workflows/teamcity-services-diff-check-beta.yml b/.github/workflows/teamcity-services-diff-check-beta.yml
@@ -18,6 +18,8 @@ jobs:
     needs: terraform-provider-google-beta
     runs-on: ubuntu-22.04
     steps:
+      - uses: actions/checkout@v3
+
       - name: Download built artifacts
         uses: actions/download-artifact@v2
         with:

diff --git a/.github/workflows/teamcity-services-diff-check-ga.yml b/.github/workflows/teamcity-services-diff-check-ga.yml
@@ -18,6 +18,12 @@ jobs:
     needs: terraform-provider-google
     runs-on: ubuntu-22.04
     steps:
+      - uses: actions/checkout@v3
+
+      - name: this
+        run: |
+         cd tools/teamcity-diff-check
+         go run main.go google services_ga.kt
       - name: Download built artifacts
         uses: actions/download-artifact@v2
         with:
@@ -51,5 +57,5 @@ jobs:
 
       - name: Diff Check
         run: |
-          cd .teamcity/components/inputs
-          go run diff_check.go google services_ga.kt
+          cd tools/teamcity-diff-check
+          go run main.go google services_ga.kt
diff --git a/....teamcity/components/inputs/diff_check.go → tools/teamcity-diff-check/main.go b/....teamcity/components/inputs/diff_check.go → tools/teamcity-diff-check/main.go
@@ -12,16 +12,20 @@ package main
 import (
 	"bufio"
 	"bytes"
+	"flag"
 	"fmt"
 	"io"
 	"os"
 	"os/exec"
 	"regexp"
 )
 
+var serviceFile = flag.String("service_file", "services_ga.kt", "kotlin service file to be parsed")
+var provider = flag.String("provider", "google", "Specify which provider to run diff_check on")
+
 func main() {
-	repo := os.Args
-	services := fmt.Sprintf("../../../%v/services/...", repo[1])
+	flag.Parse()
+	services := fmt.Sprintf("../%v/services/...", *provider)
 	fmt.Println(services)
 	cmd := exec.Command("go", "list", services)
 	stdout, err := cmd.Output()
@@ -47,8 +51,7 @@ func main() {
 
 	////////////////////////////////////////////////////////////////////////////////
 
-	service_file := os.Args[2]
-	f, err := os.Open(service_file)
+	f, err := os.Open(*serviceFile)
 	if err != nil {
 		panic(err)
 	}
@@ -85,7 +88,7 @@ func main() {
 	}
 
 	if !bytes.Equal(googleServices, teamcityServices) {
-		fmt.Fprintf(os.Stderr, "error: diff in services_ga.kt\n")
+		fmt.Fprintf(os.Stderr, "error: diff in %s\n", *serviceFile)
 		os.Exit(1)
 	}
 }