Adding authentication extension api to enable the extending of MSAL #4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2024 23:50
trwalke
changed the title
trwalke
commented
Jul 23, 2024
# Conflicts: # tests/Microsoft.Identity.Test.Unit/pop/PoPTests.cs
Adding unit tests
# Conflicts: # src/client/Microsoft.Identity.Client/ApiConfig/Parameters/AcquireTokenCommonParameters.cs # src/client/Microsoft.Identity.Client/Cache/Items/MsalAccessTokenCacheItem.cs # src/client/Microsoft.Identity.Client/Extensibility/AbstractConfidentialClientAcquireTokenParameterBuilderExtension.cs # tests/Microsoft.Identity.Test.Common/Core/Mocks/MockHttpManagerExtensions.cs
bgavrilMS
reviewed
Sep 20, 2024
src/client/Microsoft.Identity.Client/AuthScheme/IAuthenticationScheme.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 20, 2024
tests/Microsoft.Identity.Test.Unit/PublicApiTests/ExtensiblityTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 20, 2024
tests/Microsoft.Identity.Test.Unit/CDT/CdtAuthenticationScheme.cs
Outdated
Show resolved
Hide resolved
added 3 commits
September 23, 2024 21:59
# Conflicts: # src/client/Microsoft.Identity.Client/Cache/Items/MsalAccessTokenCacheItem.cs # src/client/Microsoft.Identity.Client/Extensibility/AbstractConfidentialClientAcquireTokenParameterBuilderExtension.cs # src/client/Microsoft.Identity.Client/OAuth2/MsalTokenResponse.cs # tests/Microsoft.Identity.Test.Common/Core/Mocks/MockHelpers.cs # tests/Microsoft.Identity.Test.Common/Core/Mocks/MockHttpManagerExtensions.cs # tests/Microsoft.Identity.Test.Unit/PublicApiTests/ExtensiblityTests.cs
bgavrilMS
reviewed
Oct 16, 2024
src/client/Microsoft.Identity.Client/Extensibility/MsalAuthenticationExtension.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 16, 2024
...tity.Client/Extensibility/AbstractConfidentialClientAcquireTokenParameterBuilderExtension.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 16, 2024
src/client/Microsoft.Identity.Client/Microsoft.Identity.Client.csproj
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 16, 2024
...s/Microsoft.Identity.Test.Integration.netcore/SeleniumTests/DeviceCodeFlowIntegrationTest.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Oct 16, 2024
clean up
gladjohn
reviewed
Oct 16, 2024
src/client/Microsoft.Identity.Client/AuthScheme/Bearer/BearerAuthenticationOperation.cs
Show resolved
Hide resolved
gladjohn
reviewed
Oct 16, 2024
src/client/Microsoft.Identity.Client/AuthScheme/PoP/PopAuthenticationOperation.cs
Show resolved
Hide resolved
gladjohn
reviewed
Oct 16, 2024
src/client/Microsoft.Identity.Client/AuthScheme/PoP/PopBrokerAuthenticationOperation.cs
Show resolved
Hide resolved
gladjohn
reviewed
Oct 16, 2024
...lient/Microsoft.Identity.Client/AuthScheme/SSHCertificates/SSHCertAuthenticationOperation.cs
Show resolved
Hide resolved
gladjohn
reviewed
Oct 16, 2024
gladjohn
reviewed
Oct 16, 2024
tests/Microsoft.Identity.Test.Unit/AuthExtension/AuthenticationOperationTests.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Oct 16, 2024
tests/Microsoft.Identity.Test.Unit/AuthExtension/AuthenticationOperationTests.cs
Show resolved
Hide resolved
gladjohn
reviewed
Oct 16, 2024
tests/Microsoft.Identity.Test.Unit/AuthExtension/MsalTestAuthenticationOperation.cs
Show resolved
Hide resolved
gladjohn
reviewed
Oct 16, 2024
src/client/Microsoft.Identity.Client/AuthScheme/PoP/PopBrokerAuthenticationOperation.cs
Show resolved
Hide resolved
gladjohn
reviewed
Oct 16, 2024
...tity.Client/Extensibility/AbstractConfidentialClientAcquireTokenParameterBuilderExtension.cs
Outdated
Show resolved
Hide resolved
gladjohn
approved these changes
Oct 16, 2024
added 2 commits
October 16, 2024 20:53
rayluo
reviewed
Oct 17, 2024
src/client/Microsoft.Identity.Client/AuthenticationResultMetadata.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ray Luo <[email protected]> Co-authored-by: Gladwin Johnson <[email protected]>
|
API has been decided already and is being used in MISE. Will update on next release |
when are we planning on a MSAL release with this? |
gladjohn
reviewed
Oct 17, 2024
src/client/Microsoft.Identity.Client/AuthScheme/IAuthenticationOperation.cs
Show resolved
Hide resolved
@gladjohn planning on releasing by tomorrow. We are going to come back and do an incremental update after this where we can add your api proposal. The api is set to experimental for the time being. We are targeting a preview release of this in MISE later this month so they need a package sooner than later. Thanks for the review @gladjohn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
#4956
Changes proposed in this request
Renaming
IAuthenticationSchemetoIAuthenticationOperationbecause it is being exposed for extending.Adding
WithAuthenticationExtensionapi to enable external extensions.Please see
AuthenticationOperationTests.csfor a demonstration of the new apiTesting
Added unit testing.
Performance impact
N/A
Documentation