Tryit comment use bot token instead #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
daviwil,
markcowl and
allenjzhang
as code owners
weshaggard
reviewed
Dec 12, 2023
timotheeguerin
changed the title
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/7/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/7/ |
weshaggard
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting a comment on a PR is a permission the azure pipeline doesn't get when building a fork regardless of who's fork it is unless the main repo is private. As we made this repo public, the tryit comment cannot be created by the ado pipeline anymore and we have to do the same thing as in
mcrosoft/typespecwhere a github action will create the comment for ahead of time.Core PR microsoft/typespec#2749