Added ARG queries to A01.28 in afd_checklist.en.json #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ARG queries to A01.28 in afd_checklist.en.json
erjosito
requested changes
Sep 26, 2024
checklists/afd_checklist.en.json
Outdated
| @@ -175,6 +175,7 @@ | |||
| "guid": "2902d8cc-1b0c-4495-afad-624ab70f7bd6", | |||
| "id": "A01.28", | |||
| "severity": "High", | |||
| "graph" : "resources | where type == "microsoft.network/frontdoorwebapplicationfirewallpolicies" | where properties['policySettings']['mode'] == "Detection"| extend compliant = (properties['policySettings']['mode'] == "Detection")| distinct id, compliant", | |||
There was a problem hiding this comment.
- Please use single quotes (instead of double quotes) inside of the ARG query string
- Please use the
=~operator for comparisons
… in afd_checklist.en.json Added reviewed or suggested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ARG queries to A01.28 in afd_checklist.en.json
Description
Please provide a detailed description of your changes.
Related Issue
Link to any related issues or discussions here. This helps reviewers understand the context and the need for your changes.
Checklist
Additional Information
Is there any additional context, screenshots, or considerations that might help in the review process? Please include them here.
Reviewer Notes
Is there a specific area you’d like feedback on? Please highlight it here. We're here to help and learn together! 💡
Footnotes
Details on how to add Azure Resource Graph queries to recommendations can be found here. ↩