A few fixups #152
Merged
A few fixups #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cpuguy83
commented
Jan 17, 2024
•
cpuguy83
commented
- Bump go versions
- Fix broken test
- Add CI workflow to actually run unit tests
- Bump CodeQL actions for go1.21 support
- Remove autobuild since it is not needed and is broken
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Also bumps actions/checkout to latest v4 Signed-off-by: Brian Goff <[email protected]> Remove autobuild as it is not needed This is causing CI to fail, and we're alreay building all packages as part of unit testing. Signed-off-by: Brian Goff <[email protected]> Install go1.21 in codeql runner
sozercan
reviewed
Jan 18, 2024
sozercan
reviewed
Jan 18, 2024
sozercan
reviewed
Jan 18, 2024
Co-authored-by: Sertaç Özercan <[email protected]>
Co-authored-by: Sertaç Özercan <[email protected]>
sozercan
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.