Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run go mod tidy #151

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Run go mod tidy #151

merged 1 commit into from
Jan 16, 2024

Conversation

pmengelbert
Copy link
Contributor

No description provided.

@pmengelbert
Run go mod tidy
e619fb8 
Signed-off-by: Peter Engelbert <[email protected]>
@pmengelbert pmengelbert requested a review from cpuguy83 January 16, 2024 15:30
cpuguy83
cpuguy83 requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can we keep this at go1.19 for now and drop toolchain?

@pmengelbert pmengelbert deleted the pengelbert/go_mod_tidy branch January 16, 2024 22:07
@pmengelbert pmengelbert restored the pengelbert/go_mod_tidy branch January 16, 2024 22:11
@pmengelbert pmengelbert reopened this Jan 16, 2024
@cpuguy83
Copy link
Member

Per discussion, dagger requires go1.21 hence the need to bump this in the go.mod.

@cpuguy83 cpuguy83 merged commit 42c5db5 into Azure:main Jan 16, 2024
4 of 6 checks passed
@pmengelbert pmengelbert deleted the pengelbert/go_mod_tidy branch January 16, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmengelbert @cpuguy83