Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added new conditions #103

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

aagusuab
Copy link
Member

@aagusuab aagusuab commented Aug 10, 2022

Description of your changes

Fixes #

I have:

  • Added New Conditions, Progressing and Degrading.
    • Progressing (Things to note)
      • If a new manifest is being applied, progressing conditions are created.
      • If a manifest is is being updated, it is progressing.
      • If a manifest fails to apply, Applied status is false, and progressing is true.
      • Current degrading is based on if a manifest has not been applied AND available for more than 5 minutes.
    • Currently set to 5 minutes, could change.
  • Revamped already existing conditions (Available)
  • Work's condition now utilizes all 4 conditions (Applied, Progressing, Available, Degrading)
  • The Available manifest condition currently set up the same way applied is set up.
    • In order for Available Condition to take effect for manifest conditions, AppliedWork controller must be utilized, since that is where we check if we have access to the resources.
  • Read and followed Caravel's Code of conduct.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant