Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement writebuffer #8

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Implement writebuffer #8

merged 7 commits into from
Nov 6, 2023

Conversation

jveski
Copy link
Collaborator

@jveski jveski commented Nov 3, 2023

Adds the first bit of code in the reconstitution package that will be responsible for handling each element of ResourceSlices as individual resources.

.github/workflows/unit.yaml Outdated Show resolved Hide resolved
@AYM1607
Copy link
Contributor

AYM1607 commented Nov 3, 2023

I haven't read through all the code, so this might be addressed there: How do we ensure we don't read before these async ops are committed? Is this where the informer cache abstraction comes in?

@jveski
Copy link
Collaborator Author

jveski commented Nov 6, 2023

I haven't read through all the code, so this might be addressed there: How do we ensure we don't read before these async ops are committed? Is this where the informer cache abstraction comes in?

The logic to determine if a write is needed is itself pushed onto the write queue. So we don't read from back in time relative to the write i.e. the controller that writes the status doesn't read it.

Copy link
Contributor

@AYM1607 AYM1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@jveski jveski merged commit 8363abd into main Nov 6, 2023
2 checks passed
@jveski jveski deleted the writebuffer branch November 6, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants